Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Create and copy public link to clipboard" for Spaces #11079

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Aug 3, 2023

This feature didn't work correctly, users were always redirected to the web frontend. This menu item is now disabled, waiting for a new sharing API.

@erikjv erikjv requested a review from TheOneRing August 3, 2023 10:34
@erikjv erikjv self-assigned this Aug 3, 2023
This feature didn't work correctly, users were always redirected to the
web frontend. This menu item is now disabled, waiting for a new sharing
API.
@erikjv erikjv force-pushed the work/disable-share-link-creation-for-spaces branch from 74fd19c to 89510df Compare August 3, 2023 10:37
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@erikjv erikjv merged commit 64e66db into master Aug 3, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/disable-share-link-creation-for-spaces branch August 3, 2023 14:57
@saw-jan
Copy link
Member

saw-jan commented Aug 4, 2023

Tested with ownCloud 5.0.0.11647-daily20230804 64e66d ✔️

Screenshot from 2023-08-04 10-02-48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants